Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): use lib.points #99

Merged
merged 6 commits into from
Sep 24, 2024
Merged

refactor(client): use lib.points #99

merged 6 commits into from
Sep 24, 2024

Conversation

solareon
Copy link
Contributor

@solareon solareon commented Sep 19, 2024 •
edited
Loading

Description

removes permanently spawned vehicles opting for lib.points that dynamically create and remove vehicles as needed. Also refactors the optional gabz pdm config for those using that MLO.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

mafewtm
mafewtm previously approved these changes Sep 19, 2024
View reviewed changes
D4isDAVID
D4isDAVID reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@D4isDAVID D4isDAVID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add English too

@solareon
Copy link
Contributor Author

Make sure to add English too

Helps if I hit save before pressing commit

D4isDAVID
D4isDAVID requested changes Sep 24, 2024
View reviewed changes
solareon and others added 5 commits September 24, 2024 09:54
@solareon
refactor(client): use lib.points
d146be2 
removes permanently spawned vehicles opting for lib.points that dynamically create and remove vehicles as needed. Also refactors the optional gabz pdm config for those using that MLO.
@solareon
chore(readme): update README
b436bfe
@solareon
fix: locales (en)
ed49029
@solareon @D4isDAVID
refactor(client): don't remove points on model change
12826ac 
Co-authored-by: David Malchin <[email protected]>
@solareon
refactor(client): store points in table
f7f413f
@solareon solareon added the enhancement New feature or request label Sep 24, 2024
@mafewtm mafewtm merged commit accae86 into main Sep 24, 2024
4 checks passed
@mafewtm mafewtm deleted the refactor-points branch September 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafewtm mafewtm mafewtm approved these changes

@D4isDAVID D4isDAVID D4isDAVID approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solareon @mafewtm @D4isDAVID